1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
200
|
import { randomUUID } from "node:crypto";
import { Widget, WidgetRequest, WidgetT } from "@/shared/schema";
import { expect, mock, test } from "bun:test";
import { ConsumerRequestProcessor } from "@/consumer/processor";
import { VoidLogger } from "@/shared/t";
const widgetDAOFactory = (): any => {
return {
retrieve: mock(async (widget: WidgetT) => {
return widget;
}),
save: mock(async (widget: WidgetT) => {
return widget;
}),
delete: mock(async (widget: WidgetT) => {
return widget;
}),
};
};
test("when create request then warns when already existant and not save", async () => {
const logger = new VoidLogger();
logger.warn = mock((_s) => {});
const mockWidgetDAO = widgetDAOFactory();
mockWidgetDAO.retrieve = mock(async (widget: WidgetT) => widget);
const newWidgetRequest = WidgetRequest.parse({
type: "create",
requestId: randomUUID(),
owner: "simponic",
widgetId: randomUUID(),
});
const processor = new ConsumerRequestProcessor(mockWidgetDAO, logger);
await processor.processRequest(newWidgetRequest);
expect(mockWidgetDAO.retrieve).toHaveBeenCalledTimes(1);
expect(mockWidgetDAO.save).toHaveBeenCalledTimes(0);
expect(logger.warn).toHaveBeenCalledTimes(1);
});
test("when create request then saves in dao if not exist", async () => {
const logger = new VoidLogger();
const mockWidgetDAO = widgetDAOFactory();
mockWidgetDAO.retrieve = mock(async (_widget: WidgetT) => {
return undefined;
});
const newWidgetRequest = WidgetRequest.parse({
type: "create",
requestId: randomUUID(),
owner: "simponic",
widgetId: randomUUID(),
});
const processor = new ConsumerRequestProcessor(mockWidgetDAO, logger);
await processor.processRequest(newWidgetRequest);
expect(mockWidgetDAO.retrieve).toHaveBeenCalledTimes(1);
expect(mockWidgetDAO.save).toHaveBeenCalledTimes(1);
});
test("when delete request then fails and warns if not exists", async () => {
const logger = new VoidLogger();
logger.warn = mock((_s) => {});
const mockWidgetDAO = widgetDAOFactory();
mockWidgetDAO.retrieve = mock(async (_widget: WidgetT) => {
return undefined;
});
const deleteWidgetRequest = WidgetRequest.parse({
type: "delete",
requestId: randomUUID(),
owner: "simponic",
widgetId: randomUUID(),
});
const processor = new ConsumerRequestProcessor(mockWidgetDAO, logger);
await processor.processRequest(deleteWidgetRequest);
expect(mockWidgetDAO.retrieve).toHaveBeenCalledTimes(1);
expect(mockWidgetDAO.delete).toHaveBeenCalledTimes(0);
expect(logger.warn).toHaveBeenCalledTimes(1);
});
test("when delete request then success if exists", async () => {
const logger = new VoidLogger();
const mockWidgetDAO = widgetDAOFactory();
mockWidgetDAO.retrieve = mock(async (widget: WidgetT) => {
return widget;
});
const deleteWidgetRequest = WidgetRequest.parse({
type: "delete",
requestId: randomUUID(),
owner: "simponic",
widgetId: randomUUID(),
});
const processor = new ConsumerRequestProcessor(mockWidgetDAO, logger);
await processor.processRequest(deleteWidgetRequest);
expect(mockWidgetDAO.retrieve).toHaveBeenCalledTimes(1);
expect(mockWidgetDAO.delete).toHaveBeenCalledTimes(1);
});
test("when update request then deletes empty string values", async () => {
const logger = new VoidLogger();
const testWidget = Widget.parse({
id: "test-widget",
owner: "simponic",
label: "current label",
});
const mockWidgetDAO = widgetDAOFactory();
mockWidgetDAO.retrieve = mock(async (_widget: WidgetT) => testWidget);
const updateWidgetRequest = WidgetRequest.parse({
type: "update",
requestId: randomUUID(),
owner: "simponic",
widgetId: testWidget.id,
label: "",
});
const processor = new ConsumerRequestProcessor(mockWidgetDAO, logger);
await processor.processRequest(updateWidgetRequest);
expect(mockWidgetDAO.retrieve).toHaveBeenCalledTimes(1);
expect(mockWidgetDAO.save).toHaveBeenCalledTimes(1);
expect(mockWidgetDAO.save.mock.calls[0][0]).toEqual(
Widget.parse({ id: "test-widget", owner: "simponic" }), // "label" has been removed
);
});
test("when update attempts to overwrite owner then update fails and warns", async () => {
const logger = new VoidLogger();
logger.warn = mock((_s) => {});
const testWidget = Widget.parse({
id: "test-widget",
owner: "simponic",
label: "current label",
});
const mockWidgetDAO = widgetDAOFactory();
mockWidgetDAO.retrieve = mock(async (_widget: WidgetT) => testWidget);
const newWidgetRequest = WidgetRequest.parse({
type: "update",
requestId: randomUUID(),
owner: "newOwner",
widgetId: testWidget.id,
});
const processor = new ConsumerRequestProcessor(mockWidgetDAO, logger);
await processor.processRequest(newWidgetRequest);
expect(mockWidgetDAO.retrieve).toHaveBeenCalledTimes(1);
expect(mockWidgetDAO.save).toHaveBeenCalledTimes(0);
expect(logger.warn).toHaveBeenCalledTimes(1);
});
test("when update mutable attribute field unspecified then not overwritten", async () => {
const logger = new VoidLogger();
const testWidget = Widget.parse({
id: "test-widget",
owner: "simponic",
label: "non-overwritten label",
});
const mockWidgetDAO = widgetDAOFactory();
mockWidgetDAO.retrieve = mock(async (_widget: WidgetT) => testWidget);
const newWidgetRequest = WidgetRequest.parse({
type: "update",
requestId: randomUUID(),
owner: testWidget.owner,
widgetId: testWidget.id,
description: "",
});
const processor = new ConsumerRequestProcessor(mockWidgetDAO, logger);
await processor.processRequest(newWidgetRequest);
expect(mockWidgetDAO.retrieve).toHaveBeenCalledTimes(1);
expect(mockWidgetDAO.save).toHaveBeenCalledTimes(1);
expect(mockWidgetDAO.save.mock.calls[0][0]).toEqual(
Widget.parse({
id: "test-widget",
owner: "simponic",
label: "non-overwritten label",
}),
);
});
|
